-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST GH27994 Add test for dropping empty list / index for a DataFrame … #42746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with a non-unique datetime index.
I spent some time to look at the original ticket and testing out some of the scenarios mentioned in pandas==0.25.0 and master. It looks like only in the exact reported example would an error appear in 0.25.0:
There was no difference between dropping using an empty list vs. empty datetimeindex. However, I decided to test both because list-like values are supported and although a list is the most simple the example used a datetimeindex. Like mentioned, this is now fixed on master. I only wrote a test for [3], the very specific scenario in which the Bug was reported. But let me know if anyone thinks we should add more of these scenarios. |
Looks like there are some failures on 'Checks' - 'Running doctests'
I don't think it's related to my Pull Request but going to take a look to see why it's failing or if there's an Open Issue. |
Yeah they are unrelated |
thanks @mikephung122 |
…with a non-unique datetime index.